Add support for REST server extensions #1101
Conversation
api/server/sdk/rest_gateway.go
Outdated
| @@ -155,6 +168,11 @@ func (s *sdkRestGateway) restServerSetupHandlers() (http.Handler, error) { | |||
| } | |||
| } | |||
|
|
|||
| // Register extra services provided | |||
| if err := s.registerServerExtensions(gmux, conn); err != nil { | |||
There was a problem hiding this comment.
If we do it this way, the caller will have to setup a function with a for loop to register their functions. During registering of the gRPC function, the single function the caller registers does not need a loop.
I think it would be cleaner to accept an array of handlers that take (ctx, gmux, conn) that way they can be appended to the handlers on line 164 and automatically registered.
What do you think?
There was a problem hiding this comment.
The works too - that's one of the ways I considered setting it up for gRPC. I was thinking that the way we set them up should be similar for both gRPC and REST, as but as long as we document the behavior it should be fine.
I can change it to accept a slice of handlers
There was a problem hiding this comment.
@lpabon I've changed it to just be a slice of handlers, and they're started the same way as the core handlers are created.
Signed-off-by: Grant Griffiths <[email protected]>
ggriffiths
force-pushed
the
rest_server_extensions
branch
from
98fe9fe to
93e40ac
Compare
Signed-off-by: Grant Griffiths [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional)
Closes #1100
Special notes for your reviewer: